Memory Leaking. _talloc_zero panics
Sylvain Munaut
246tnt at gmail.com
Sun Feb 21 18:03:08 CET 2010
> I will think about how to solve this. Either we introduce some busy-waiting
> until more space is available, or I will try to fill existing buffers even
> beyond the end-of-line.
I've seen the commit to fill up the msgb more. But this exposed
another bug in msgb I think.
The headroom allocation doesn't work AFAICT. In msgb.h there is :
static inline int msgb_tailroom(const struct msgb *msgb)
{
return (msgb->data + msgb->data_len) - msgb->tail;
}
/* increase the headroom of an empty msgb, reducing the tailroom */
static inline void msgb_reserve(struct msgb *msg, int len)
{
msg->data += len;
msg->tail += len;
}
So when reserving N bytes, the msgb_tailroom isn't decremented ... I'm
currently looking for a fix that doesn't break anything else :)
Sylvain
More information about the baseband-devel
mailing list