AW: Some refactoring proposals

[Andreas.Eversberg]

surely i agree! (as i noted in my last mail)

-----Ursprüngliche Nachricht-----
Von: Harald Welte [mailto:laforge at gnumonks.org] 
Gesendet: Mittwoch, 28. Juli 2010 09:17
An: Sylvain Munaut
Cc: baseband-devel; Andreas.Eversberg
Betreff: Re: Some refactoring proposals

On Tue, Jul 27, 2010 at 09:02:02PM +0200, Sylvain Munaut wrote:
> Hi,
> 
> >> * Split layer23/src into
> >>   - common: what makes liblayer23, purely generic stuff that needs
> >> binding together to define an app
> >>   - mobile: The real complete mobile application
> >>   - misc: The test applications and their support code layer23 (which
> >> I'd rename bcch_dump since that's what it does), echo_test, bcch_scan)
> >
> > Sounds fine with me.  If Andreas doesn't mind, I'm happy to merge a branch
> > containing this split
> 
> Ok, this is done. It's waiting in my pending branch with a bunch of
> other fixes. It requires a libosmocore update as well.

I'll wait for some feedback from Andreas. If he either agrees or doesn't care,
then I'll merge it.

> (I moved a func to libosmocore, which required to update it, which
> bringed the msgb checks, which broke the target build and required
> fixing, it also showed some bugs in fw and layer23 code that required
> fixing as well ...)

I've merged your pending libosmocore changes to libosmocore.git master.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)