[PATCH] SAP client

[Nico Golde]

Hi,
I'm also in favor for BTSAP. I personally find the protocol 
fairly sane and like Kevin mentioned there is also already 
the SAP server implementation in the osmocom repositories.

* jolly <andreas at eversberg.eu> [2011-11-07 17:31]:
> nice work. i like the idea that BTSAP is used by layer23. this was my
> intention when i added the sap_interface.c. not only that layer23 can
> use softsim as reader, but also other btsap clients could use osmocombb
> as reader.

I didn't even think of this option so far, but it's a good 
idea and shouldn't be too difficult to add to the current 
code!

> to make this possible, the next step would be adding the
> btsap server socket to osmocon. (currently it only provides a socket for
> L1CTL.) also layer1 sim reader would require to get a btsap compatible
> interface.
> 
> there is only one thing i disagree: you implemented function in the VTY
> to set the socket. this is already done in the configurations of each
> mobile instance. i would suggest that you open the socket
> (osmosap_init(ms)) at app_mobile.c when the instance is started (no
> shutdown), in case the socket is given. then, if the mobile instance
> starts working, the socket will be connected and the sim client will
> read the sim as soon as the socket is connected.

I totally agree. I think the reason I did it this way was 
for simplicity because when the reader and the SAP interface 
are activated manually subsequently, the ATR command will already
have it's reply. If it's not done this way the mobile 
application would have to wait for it to complete because 
the process is fairly slow. But the cleaner way would be 
app_mobile.c. I can work on that but will likely need some 
time due to various other commitments at the moment.

Kind regards
Nico