cppcheck/pyflakes results for osmocom-bb

[Paul Wise]

Hi all,

I noticed that cppcheck and pyflakes are detecting some possible issues
in the osmocom-bb codebase on the master branch:

./src/target_dsp/calypso/dump2coff.py:3: 'namedtuple' imported but unused
./src/host/fb_tools/bdf_to_c.py:30: 'string' imported but unused

[src/host/layer23/src/common/main.c:146]: (error) Possible null pointer dereference: app_opp
[src/host/gsmmap/gsmmap.c:379] -> [src/host/gsmmap/gsmmap.c:384]: (error) Possible null pointer dereference: meas - otherwise it is redundant to check it against null.
[src/shared/libosmocore/src/gb/gprs_bssgp.c:1076] -> [src/shared/libosmocore/src/gb/gprs_bssgp.c:1041]: (error) Possible null pointer dereference: dup - otherwise it is redundant to check it against null.
[src/shared/libosmocore/src/gb/gprs_bssgp.c:1087] -> [src/shared/libosmocore/src/gb/gprs_bssgp.c:1041]: (error) Possible null pointer dereference: dup - otherwise it is redundant to check it against null.
[src/shared/libosmocore/src/gb/gprs_bssgp.c:1088] -> [src/shared/libosmocore/src/gb/gprs_bssgp.c:1041]: (error) Possible null pointer dereference: dup - otherwise it is redundant to check it against null.
[src/shared/libosmocore/src/gsm/lapd_core.c:1936] -> [src/shared/libosmocore/src/gsm/lapd_core.c:1948]: (error) Possible null pointer dereference: msg - otherwise it is redundant to check it against null.
[src/target/firmware/apps/chainload/main.c:39]: (error) Possible null pointer dereference: entry
[src/target/firmware/apps/loader/main.c:92]: (error) Possible null pointer dereference: entry
[src/target/firmware/apps/loader_mtk/main.c:87]: (error) Possible null pointer dereference: entry
[src/target/ui-experiment/png2tiny.c:20]: (error) printf format string has 1 parameters but only 0 are given.
[src/target/firmware/rf/mt6139.c:138]: (error) Uninitialized variable: pga_gain

-- 
bye,
pabs

http://bonedaddy.net/pabs3/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20120929/9f7d8e50/attachment.pgp>