[PATCH] COMP128v23 improvements

[☎]

19.11.2013 09:17, Sylvain Munaut пишет:
> Hi Max,
> 
> There are definitely things weird in that patch :
> 
>  - You double declare the same function

Which one?

>  - Why replace #defined constant by hardcoded numbers ?

To make code look more similar to comp128v1 and other code which uses Kc and rand: we
use hardcoded values everywhere.


>  - Speaking about readability :
> 
> kc[6] = 4 * (kc[6] >> 2);
> 
> isn't the most obvious way to do kc[6] &= 0xfc;

Added, thank you.


-- 
best regards,
Max, http://fairwaves.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-COMP128v23-implementation-and-add-test-suit-v2.patch
Type: text/x-patch
Size: 188101 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20131119/4ed9360f/attachment-0001.bin>