[PATCH] COMP128v23 improvements

[☎]

19.11.2013 12:16, Peter Stuge пишет:

> 
> Since this is a public API I don't know if the old function can be removed.
> 

I thought public api is in auth_comp128* e. g. osmo_auth_gen_vec() - see
tests/comp128_test.c for usage examples. And functions like comp128v*() are internal
implementation details.

>> +int comp128v3(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc);
>> +int comp128v3(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc);
> 
> Copypaste error here. I think it's nice to add two new functions, but
> probably the old one needs to stay there.
> 
> 

Fixed, thank you.


-- 
best regards,
Max, http://fairwaves.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-COMP128v23-implementation-and-add-test-suit-v3.patch
Type: text/x-patch
Size: 188101 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20131119/ada7d133/attachment-0001.bin>