[PATCH] Add generic LE/BE load/store uint type convertors and use them in msgb

Max.Suraev at fairwaves.ru
Fri Jan 31 15:10:48 CET 2014


v3 attached, comments are inline.

31.01.2014 12:26, Holger Hans Peter Freyther пишет:

> tests is some how important. At least knowing that all routines got
> executed at least once.

Added.

> C89 didn't have this style of comments. Use /* */ but maybe
> consider using api comments above the function instead of
> directly after {?

I've converted my comments but I'd like to point out that libosmocore does not
actually follow this style - just do
git grep -n "//"|grep -v http
to verify.


> this is not lisp.

Yepp, that makes me sad too :)
Anyway, fixed.


-- 
best regards,
Max, http://fairwaves.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-generic-LE-BE-load-store-uint-type-convertors.patch
Type: text/x-patch
Size: 18967 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20140131/712e263a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-Kasumi-cipher-implementation.patch
Type: text/x-patch
Size: 24083 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20140131/712e263a/attachment-0003.bin>


More information about the baseband-devel mailing list