[PATCH] use osmocom auth API instead of direct calls

---
 .../layer23/include/osmocom/bb/mobile/settings.h   |  6 ----
 src/host/layer23/src/mobile/subscriber.c           | 33 ++++++++++------------
 src/host/layer23/src/mobile/vty_interface.c        |  9 +++---
 3 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/src/host/layer23/include/osmocom/bb/mobile/settings.h b/src/host/layer23/include/osmocom/bb/mobile/settings.h
index f3ac796..cdf6323 100644
--- a/src/host/layer23/include/osmocom/bb/mobile/settings.h
+++ b/src/host/layer23/include/osmocom/bb/mobile/settings.h
@@ -1,12 +1,6 @@
 #ifndef _settings_h
 #define _settings_h

-/* type of test SIM key */
-enum {
-	GSM_SIM_KEY_XOR = 0,
-	GSM_SIM_KEY_COMP128
-};
-
 struct gsm_settings {
 	char			layer2_socket_path[128];
 	char			sap_socket_path[128];
diff --git a/src/host/layer23/src/mobile/subscriber.c b/src/host/layer23/src/mobile/subscriber.c
index fa59d9f..ba3c328 100644
--- a/src/host/layer23/src/mobile/subscriber.c
+++ b/src/host/layer23/src/mobile/subscriber.c
@@ -24,7 +24,7 @@
 #include <string.h>
 #include <arpa/inet.h>

Re: [PATCH] use osmocom auth API instead of direct calls

This patch switches away from directly calling COMP128 to using generic osmocom
authentication API. The idea is that bypassing auth API will be deprecated in future
versions of libosmocore. Using generic API will allow us to trivially introduce
support for other algorithms like COMP128v23 for example.

Note: I'd appreciate help with testing to make sure there are no regressions.

-- best regards,
Max,
http://fairwaves.co

Re: [PATCH] use osmocom auth API instead of direct calls

Re: [PATCH] use osmocom auth API instead of direct calls

Something like this:

cd osmocom-bb
patch -p1 < "use osmocom auth API instead of direct calls.patch"

06.06.2014 21:37, Choukou Moun пишет:
> Hello,
> 
> Im sorry for this newbies question but how to appling this patch to my osmocom-bb
> install ?
> 
> Thanks for the plsong time to respond to me
> 
> Best.
> 
> Le 6 juin 2014 15:53, "☎" <Max.Suraev@fairwaves.co <mailto:Max.Suraev@fairwaves.co>>
> a écrit :
> 
>     This patch switches away from directly calling COMP128 to using generic osmocom
>     authentication API. The idea is that bypassing auth API will be deprecated in future
>     versions of libosmocore. Using generic API will allow us to trivially introduce
>     support for other algorithms like COMP128v23 for example.
> 
>     Note: I'd appreciate help with testing to make sure there are no regressions.
> 
>     -- best regards,
>     Max,
>     http://fairwaves.co
> 
> 

--

-- 
best regards,
Max, http://fairwaves.co

Re: [PATCH] use osmocom auth API instead of direct calls

On Sat, Jun 7, 2014 at 7:52 AM, ☎ <Max.Suraev@fairwaves.co> wrote:

> Something like this:
>
> cd osmocom-bb
> patch -p1 < "use osmocom auth API instead of direct calls.patch"

A better way to do it would be to save the mail as an mbox and then
run this. That way you get a proper commit in the git repository.

cd osmocom-bb
git am "use osmocom auth API instead of direct calls.patch"

--

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

Re: [PATCH] use osmocom auth API instead of direct calls

Instead of saving email you could get patch from
http://patchwork.ozlabs.org/project/osmocom-bb/list/

That's a convenient way to track other patches pending review as well.

07.06.2014 03:04, Paul Wise пишет:
> On Sat, Jun 7, 2014 at 7:52 AM, ☎ <Max.Suraev@fairwaves.co> wrote:
> 
>> Something like this:
>>
>> cd osmocom-bb
>> patch -p1 < "use osmocom auth API instead of direct calls.patch"
> 
> A better way to do it would be to save the mail as an mbox and then
> run this. That way you get a proper commit in the git repository.
> 
> cd osmocom-bb
> git am "use osmocom auth API instead of direct calls.patch"
> 

--

-- 
best regards,
Max, http://fairwaves.co