[PATCH] remove comp128 from public API - use osmocom/crypt/auth.h instead
Max Suraev <Max.Suraev@fairwaves.co>
2014-06-16 16:35:23 GMT
Signed-off-by: Max Suraev <Max.Suraev@fairwaves.co>
---
include/Makefile.am | 6 +++---
include/osmocom/gsm/comp128.h | 4 ++--
src/gsm/auth_comp128v1.c | 2 +-
src/gsm/comp128.c | 2 +-
src/gsm/libosmogsm.map | 1 -
tests/comp128/comp128_test.c | 1 -
6 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/include/Makefile.am b/include/Makefile.am
index 74396de..47f5e4f 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -45,8 +45,6 @@ nobase_include_HEADERS = \
osmocom/gprs/protocol/gsm_08_18.h \
osmocom/gsm/a5.h \
osmocom/gsm/abis_nm.h \
- osmocom/gsm/comp128.h \
- osmocom/gsm/comp128v23.h \
osmocom/gsm/gan.h \
osmocom/gsm/gsm0411_smc.h \
osmocom/gsm/gsm0411_smr.h \
@@ -110,7 +108,9 @@ endif
noinst_HEADERS = \
osmocom/core/timer_compat.h \
- osmocom/gsm/kasumi.h
+ osmocom/gsm/kasumi.h \
+ osmocom/gsm/comp128.h \
(Continue reading)
Re: [PATCH] remove comp128 from public API - use osmocom/crypt/auth.h instead
☎ <Max.Suraev@fairwaves.co>
2014-06-16 16:43:26 GMT
This will obviously require API version bump but it should not break any applications
which use auth.h API.
Patch for osmocom-bb to use auth.h is applied in git.
Patch for OpenBSC pending review in the ML.
If there are other open source projects using comp128 directly I'd be to assist with
transition, although it's rather trivial - see
http://patchwork.ozlabs.org/patch/356029/ for example.
cheers,
Max.
Re: [PATCH] remove comp128 from public API - use osmocom/crypt/auth.h instead
Holger Hans Peter Freyther <holger@freyther.de>
2014-06-16 17:08:51 GMT
On Mon, Jun 16, 2014 at 06:43:26PM +0200, ☎ wrote:
> This will obviously require API version bump but it should not break any applications
then please patch 'TODO-RELEASE' as well.
thanks
holger
[PATCH] remove comp128 from public API - use osmocom/crypt/auth.h instead
Max Suraev <Max.Suraev@fairwaves.co>
2014-06-17 09:56:17 GMT
Signed-off-by: Max Suraev <Max.Suraev@fairwaves.co>
---
TODO-RELEASE | 1 +
include/Makefile.am | 6 +++---
include/osmocom/gsm/comp128.h | 4 ++--
src/gsm/auth_comp128v1.c | 2 +-
src/gsm/comp128.c | 2 +-
src/gsm/libosmogsm.map | 1 -
tests/comp128/comp128_test.c | 1 -
7 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 43b1e8e..d6f8194 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -1 +1,2 @@
#library what description / commit summary line
+libosmogsm api-change remove comp128 from public API
\ No newline at end of file
diff --git a/include/Makefile.am b/include/Makefile.am
index 74396de..47f5e4f 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -45,8 +45,6 @@ nobase_include_HEADERS = \
osmocom/gprs/protocol/gsm_08_18.h \
osmocom/gsm/a5.h \
osmocom/gsm/abis_nm.h \
- osmocom/gsm/comp128.h \
- osmocom/gsm/comp128v23.h \
osmocom/gsm/gan.h \
(Continue reading)