annotate .hgignore @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 8d9298e0823a
children a490b0466fed
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6
c01d2500a998 beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 syntax: regexp
c01d2500a998 beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
c01d2500a998 beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 ^build-
467
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents: 388
diff changeset
4
472
8d9298e0823a romvecs-patch directory renamed to fcdev3b-hacks
Mychaela Falconia <falcon@freecalypso.org>
parents: 470
diff changeset
5 ^fcdev3b-hacks/src/romvecs-insert.lst$
8d9298e0823a romvecs-patch directory renamed to fcdev3b-hacks
Mychaela Falconia <falcon@freecalypso.org>
parents: 470
diff changeset
6 ^fcdev3b-hacks/src/romvecs-insert.o$
8d9298e0823a romvecs-patch directory renamed to fcdev3b-hacks
Mychaela Falconia <falcon@freecalypso.org>
parents: 470
diff changeset
7
248
35b17d54773d helpers: build-date helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 92
diff changeset
8 ^helpers/build-date$
388
b8b08c302ace cfg-hdr-gen C helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 257
diff changeset
9 ^helpers/cfg-hdr-gen$
9
05945a9b9dda makeline helper written
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
10 ^helpers/makeline$
257
d4d07c751e56 helpers: mk-flash-script helper program written
Mychaela Falconia <falcon@freecalypso.org>
parents: 248
diff changeset
11 ^helpers/mk-flash-script$
92
40b08f6cb2b8 srec4ram helper utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 60
diff changeset
12 ^helpers/srec4ram$
60
f4eeab478bfe str2ind-ver helper written
Mychaela Falconia <falcon@freecalypso.org>
parents: 9
diff changeset
13 ^helpers/str2ind-ver$