FreeCalypso > hg > fc-magnetite
annotate blobs/patches/main-pirelli.patch @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 8dd671b7d41e |
children |
rev | line source |
---|---|
87
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 # This patch applies to the Init_Target() function in the init.obj module in |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 # main.lib; the present version is for making TCS211 run on the Pirelli. |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 # This patch sets the same memory and peripheral chip select timings and |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 # widths as Pirelli's fw. |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 [init.obj] |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 # value goes into nCS0, nCS1 and nCS3 config registers |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 .text 66 A4 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 # the nCS2 setting in our original blob is already correct for the Pirelli |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 # value goes into nCS4 config reg |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 .text 72 A7 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 # nop out the write into 0x02700000 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 .text 128 C0 |
8dd671b7d41e
blobs/patches: main-pirelli and main-rvtmodem patches added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 .text 129 46 |