FreeCalypso > hg > fc-magnetite
annotate cdg-hybrid/cdginc/p_fad.val @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | e7a67accfad9 |
children |
rev | line source |
---|---|
212
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 +--------------------------------------------------------------------------+ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 | PROJECT : PROTOCOL STACK | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 | FILE : p_fad.val | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 | SOURCE : "sap\fad.pdf" | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 | LastModified : "2002-04-22" | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 | IdAndVersion : "8411.103.00.305" | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 | SrcFileTime : "Thu Nov 29 09:41:22 2007" | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 +--------------------------------------------------------------------------+ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 /* PRAGMAS |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 * PREFIX : NONE |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 * COMPATIBILITY_DEFINES : NO (require PREFIX) |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 * ALWAYS_ENUM_IN_VAL_FILE: NO |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 * ENABLE_GROUP: NO |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 * CAPITALIZE_TYPENAME: NO |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 #ifndef P_FAD_VAL |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
24 #define P_FAD_VAL |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 #define CDG_ENTER__P_FAD_VAL |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
29 #define CDG_ENTER__FILENAME _P_FAD_VAL |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
30 #define CDG_ENTER__P_FAD_VAL__FILE_TYPE CDGINC |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
31 #define CDG_ENTER__P_FAD_VAL__LAST_MODIFIED _2002_04_22 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
32 #define CDG_ENTER__P_FAD_VAL__ID_AND_VERSION _8411_103_00_305 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
33 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
34 #define CDG_ENTER__P_FAD_VAL__SRC_FILE_TIME _Thu_Nov_29_09_41_22_2007 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
35 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
36 #include "CDG_ENTER.h" |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
37 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
38 #undef CDG_ENTER__P_FAD_VAL |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
39 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
40 #undef CDG_ENTER__FILENAME |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
41 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
42 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
43 /* |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
44 * Value constants for VAL_trans_rate |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
45 */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
46 #define R_BCS (0x12c) /* rate 300 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
47 #define R_2400 (0x960) /* rate 2400 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
48 #define R_4800 (0x12c0) /* rate 4800 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
49 #define R_7200 (0x1c20) /* rate 7200 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
50 #define R_9600 (0x2580) /* rate 9600 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
51 #define R_12000 (0x2ee0) /* rate 12000 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
52 #define R_14400 (0x3840) /* rate 14400 bit/s */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
53 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
54 /* |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
55 * Value constants for VAL_mode |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
56 */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
57 #define MUX_OFF (0x0) /* ignore */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
58 #define MUX_BCS (0x1) /* BCS data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
59 #define MUX_MSG (0x2) /* MSG data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
60 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
61 /* |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
62 * Value constants for VAL_cause |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
63 */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
64 #define ERR_REM_FAD (0xcc00) /* reserved */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
65 #define ERR_REM_PREAMBLE (0xcc11) /* DATA received instead of PREAMBLE - Preamble too short */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
66 #define ERR_REM_DATA_BCS (0xcc12) /* DATA received from remote modem during BCS phase */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
67 #define ERR_REM_TRAIN_START (0xcc13) /* DATA received from remote modem at start of training */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
68 #define ERR_REM_NO_TRAINING (0xcc14) /* DATA received from remote modem prior to training */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
69 #define ERR_REM_TRAINING (0xcc15) /* DATA received from remote modem during training */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
70 #define ERR_REM_MSG (0xcc16) /* DATA received from remote modem while sending MSG data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
71 #define ERR_REM_PREAMBLE_SHORT (0xcc17) /* PREAMBLE received from remote station too short */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
72 #define ERR_REM_PREAMBLE_LONG (0xcc18) /* PREAMBLE received from remote station too long */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
73 #define ERR_REM_IDENT (0xcc19) /* Incorrect identification from remote modem */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
74 #define ERR_LOCAL_FAD (0xcc20) /* reserved */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
75 #define ERR_LOCAL_BCS_RATE (0xcc21) /* BCS rate requested by local modem (MSG phase) */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
76 #define ERR_LOCAL_MSG_RATE (0xcc22) /* MSG rate requested by local modem (BCS phase) */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
77 #define ERR_LOCAL_DATA_NULL (0xcc23) /* DATA request received from T30 in NULL state */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
78 #define ERR_LOCAL_DATA_BCS (0xcc24) /* DATA request received from T30 while receiving BCS data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
79 #define ERR_LOCAL_DATA_TCF_SND (0xcc25) /* DATA request received from T30 while sending TCF data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
80 #define ERR_LOCAL_DATA_TCF_RCV (0xcc26) /* DATA request received from T30 while receiving TCF data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
81 #define ERR_LOCAL_DATA_MSG (0xcc27) /* DATA request received from T30 while receiving MSG data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
82 #define ERR_LOCAL_DATA_UNDEF (0xcc28) /* DATA request received from T30 - state unknown */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
83 #define ERR_LOCAL_DATA_MSG_UFL (0xcc29) /* DATA request not received from T30 - MSG-REC underflow */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
84 #define ERR_LOCAL_IDENT (0xcc30) /* Incorrect identification from local modem */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
85 #define ERR_OWN_FAD (0xcc40) /* reserved */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
86 #define ERR_FAD_SUB_TRAIN (0xcc41) /* FAD in unknown substate during training */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
87 #define ERR_FAD_SUB_TCF (0xcc42) /* FAD in unknown substate (TCF) */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
88 #define ERR_FAD_SUB_MSG (0xcc43) /* FAD in unknown substate (MSG) */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
89 #define ERR_GENERAL_FAD (0xcc50) /* reserved */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
90 #define ERR_INVALID_DATA_RCV (0xcc51) /* invalid data received */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
91 #define ERR_EMPTY_BUFFER (0xcc52) /* send/receive buffer is empty */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
92 #define ERR_OVERFLOW_BCS_RCV (0xcc52) /* buffer overflow while receiving BCS data */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
93 #define ERR_NOT_SET (0xccff) /* error not set */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
94 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
95 /* |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
96 * user defined constants |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
97 */ |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
98 #define DUMMY_FAD (0x0) |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
99 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
100 #include "CDG_LEAVE.h" |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
101 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
102 |
e7a67accfad9
cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
103 #endif |