annotate cdg-hybrid/sap-inline/DIO_inline.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e7a67accfad9
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
212
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /***
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 ;*** File : DIO_inline.h
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 ;*** Creation : Wed Mar 11 09:57:46 CST 2009
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 ;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 ;*** Copyright : (c) Texas Instruments AG, Berlin Germany 2002
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 ;*** Document Type : Service Access Point Specification
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 ;*** Document Name : DIO
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 ;*** Document No. : ...
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 ;*** Document Date : 2004-03-19
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 ;*** Document Status: BEING_PROCESSED
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 ;*** Document Author: RM
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 ;*** !!! THIS INCLUDE FILE WAS GENERATED AUTOMATICALLY, DO NOT MODIFY !!!
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 ;********************************************************************************
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 ***/
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 #ifndef _DIO_INLINE_H_
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 #define _DIO_INLINE_H_
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 #include "gdi.h"
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 extern U16 dio_init ( void );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 extern U16 dio_user_init ( U32 user_name, U16 drv_handle, T_DRV_CB_FUNC signal_callback );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 extern U16 dio_user_exit ( U32 user_name );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 extern void dio_exit ( void );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 extern U16 dio_set_rx_buffer ( U32 device, T_dio_buffer *buffer );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 extern U16 dio_read ( U32 device, T_DIO_CTRL *control_info, T_dio_buffer **buffer );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 extern U16 dio_write ( U32 device, T_DIO_CTRL *control_info, T_dio_buffer *buffer );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 extern U16 dio_get_tx_buffer ( U32 device, T_dio_buffer **buffer );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 extern U16 dio_clear ( U32 device );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 extern U16 dio_flush ( U32 device );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 extern U16 dio_get_capabilities ( U32 device, T_DIO_CAP **capabilities );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 extern U16 dio_set_config ( U32 device, T_DIO_DCB *dcb );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 extern U16 dio_get_config ( U32 device, T_DIO_DCB *dcb );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 extern U16 dio_close_device ( U32 device );
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
e7a67accfad9 cdg-hybrid cdginc headers created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 #endif /* !_DIO_INLINE_H_ */