annotate cdg211/cdginc/p_tb.val @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 56abf6cf8a0b
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 +--------------------------------------------------------------------------+
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 | PROJECT : PROTOCOL STACK |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 | FILE : p_tb.val |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 | SOURCE : "__out__\g23m_dfile\prim\tb.pdf" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 | LastModified : "2001-07-17" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 | IdAndVersion : "8441.112.01.002" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 | SrcFileTime : "Mon Nov 24 15:51:14 2003" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 | Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:16 2007 |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 +--------------------------------------------------------------------------+
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 */
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 /* PRAGMAS
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 * PREFIX : NONE
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 * COMPATIBILITY_DEFINES : NO (require PREFIX)
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 * ALWAYS_ENUM_IN_VAL_FILE: NO
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 * ENABLE_GROUP: NO
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 * CAPITALIZE_TYPENAME: NO
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 */
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 #ifndef P_TB_VAL
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 #define P_TB_VAL
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 #define CDG_ENTER__P_TB_VAL
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 #define CDG_ENTER__FILENAME _P_TB_VAL
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 #define CDG_ENTER__P_TB_VAL__FILE_TYPE CDGINC
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 #define CDG_ENTER__P_TB_VAL__LAST_MODIFIED _2001_07_17
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 #define CDG_ENTER__P_TB_VAL__ID_AND_VERSION _8441_112_01_002
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 #define CDG_ENTER__P_TB_VAL__SRC_FILE_TIME _Mon_Nov_24_15_51_14_2003
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 #include "CDG_ENTER.h"
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 #undef CDG_ENTER__P_TB_VAL
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 #undef CDG_ENTER__FILENAME
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 /*
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 * Value constants for VAL_arfcn
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 */
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 #define TB_INVALID_ARFCN (0xffff) /* Used to mark a channel number entry as invalid. */
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 /*
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 * user defined constants
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 */
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 #define TB_BA_LIST_SIZE (0x21)
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 #include "CDG_LEAVE.h"
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 #endif