annotate cfg-headers/rv_swe-2091.h @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents fd8227e3047d
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 #ifndef __RV_SWE_H__
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 #define __RV_SWE_H__
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 #define RVM_ATP_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 #define RVM_AUDIO_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #define RVM_ETM_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #define RVM_DAR_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #define RVM_SPI_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #define RVM_LLS_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 #define RVM_KPD_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 #define RVM_LCC_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 #define RVM_MKS_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 #define RVM_RTC_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 #define RVM_FFS_SWE
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
53c4389afc06 cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 #endif /* __RV_SWE_H__ */