annotate components/aci_dti_mng-tcs3 @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
168
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building the TCS3.2 version of aci_dti_mng.lib
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 if [ "$SRVC" != 0 ]
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 then
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$SRVC" = 1 ]
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DFF_FAX"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 fi
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$MMI" = 0 ]
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DACI"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 elif [ "$MMI" = 2 ]
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 then
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DMFW"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 fi
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 if [ "$GPRS" = 1 ]
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 then
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DGPRS"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 fi
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 168
diff changeset
54 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 168
diff changeset
55 CPPFLAGS="$CPPFLAGS -DBOARD=41"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 168
diff changeset
56
168
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 # Includes
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-aci/aci"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-aci/aci_dti_mng"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 # Source modules
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 SRCDIR=$SRC/g23m-aci/aci_dti_mng
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70
282f1cffad52 TCS3.2 version of aci_dti_mng.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/dti_conn_mng.c