annotate components/aciext-tcs3 @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
169
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building the TCS3.2 version of aciext.lib
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version aci_ext
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain aci_ext_version.c
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 if [ "$SRVC" != 0 ]
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 then
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 if [ "$SRVC" = 1 ]
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 then
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DFF_FAX"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 fi
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 fi
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 if [ "$MMI" = 0 ]
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 then
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DACI"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 elif [ "$MMI" = 2 ]
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 then
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DMFW"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 fi
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 if [ "$GPRS" = 1 ]
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 then
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -DGPRS"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 fi
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -DSMS_PDU_SUPPORT"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -DSIM_TOOLKIT"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -DDTI2"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 477
diff changeset
61 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 477
diff changeset
62 CPPFLAGS="$CPPFLAGS -DBOARD=41"
169
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63
477
f65a4399093d hybrid config: re-enabled obscure AT commands which require TI_PS_FF_* flags
Mychaela Falconia <falcon@freecalypso.org>
parents: 169
diff changeset
64 # FreeCalypso additions to make the TCS3.2 version
f65a4399093d hybrid config: re-enabled obscure AT commands which require TI_PS_FF_* flags
Mychaela Falconia <falcon@freecalypso.org>
parents: 169
diff changeset
65 # behave more like TCS211
f65a4399093d hybrid config: re-enabled obscure AT commands which require TI_PS_FF_* flags
Mychaela Falconia <falcon@freecalypso.org>
parents: 169
diff changeset
66
f65a4399093d hybrid config: re-enabled obscure AT commands which require TI_PS_FF_* flags
Mychaela Falconia <falcon@freecalypso.org>
parents: 169
diff changeset
67 CPPFLAGS="$CPPFLAGS -DTI_PS_FF_AT_P_CMD_SECP"
f65a4399093d hybrid config: re-enabled obscure AT commands which require TI_PS_FF_* flags
Mychaela Falconia <falcon@freecalypso.org>
parents: 169
diff changeset
68 CPPFLAGS="$CPPFLAGS -DTI_PS_FF_AT_P_CMD_SECS"
f65a4399093d hybrid config: re-enabled obscure AT commands which require TI_PS_FF_* flags
Mychaela Falconia <falcon@freecalypso.org>
parents: 169
diff changeset
69
169
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 # Includes
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-aci/aci"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-aci/aci_ext"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I.."
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I../config"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
101 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
103 # Source modules
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
104
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
105 SRCDIR=$SRC/g23m-aci/aci_ext
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
106
825d15577a21 TCS3.2 version of aciext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
107 cfile_str2ind $SRCDIR/aci_ext_pers.c