annotate components/atiext-classic @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents fe3455406f7f
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
22
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building the classic TCS211 version of atiext.lib
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version ati_ext
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain ati_ext_version.c
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 if [ "$SRVC" != 0 ]
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 then
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 if [ "$SRVC" = 1 ]
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 then
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DFF_FAX"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 fi
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 fi
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 if [ "$MMI" = 0 ]
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 then
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DACI"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 elif [ "$MMI" = 2 ]
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 then
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DMFW"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 fi
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 if [ "$GPRS" = 1 ]
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 then
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -DGPRS"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 fi
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -DSMS_PDU_SUPPORT"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -DSIM_TOOLKIT"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 # Includes
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/aci2/aci"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/aci2/ati_ext"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 # Source modules
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 SRCDIR=$SRC/aci2/ati_ext
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74
fe3455406f7f atiext.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 cfile_str2ind $SRCDIR/ati_ext_mech.c