annotate components/atiext-tcs3 @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
170
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building the TCS3.2 version of atiext.lib
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version ati_ext
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain ati_ext_version.c
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 if [ "$SRVC" != 0 ]
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 then
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 if [ "$SRVC" = 1 ]
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 then
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DFF_FAX"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 fi
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 fi
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 if [ "$MMI" = 0 ]
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 then
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DACI"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 elif [ "$MMI" = 2 ]
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 then
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DMFW"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 fi
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 if [ "$GPRS" = 1 ]
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 then
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -DGPRS"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 fi
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -DSMS_PDU_SUPPORT"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -DSIM_TOOLKIT"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 170
diff changeset
60 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 170
diff changeset
61 CPPFLAGS="$CPPFLAGS -DBOARD=41"
170
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 # Includes
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-aci/aci"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-aci/ati_ext"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 # Source modules
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 SRCDIR=$SRC/g23m-aci/ati_ext
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76
0d6201c64829 TCS3.2 version of atiext.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_str2ind $SRCDIR/ati_ext_mech.c