annotate components/audio_bgd @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents a514d3bd20c4
children 838eeafb0051
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
33
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building audio_bgd.lib
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -mw -me -pw2"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 # Includes
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -I.."
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -I../config"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 # Source modules
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 SRCDIR=$SRC/cs/services/Audio/Audio_bgd
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 cfile_plain $SRCDIR/audio_bgd_env.c
a514d3bd20c4 audio_bgd.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 cfile_plain $SRCDIR/audio_bgd_task.c