annotate components/cc @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
155
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building cc.lib from the TCS3.2 source
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version cc
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain cc_version.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$GPRS" = 1 ]
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DGPRS"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
305
9026fa2630e4 components/cc: new CC needs -DSIM_TOOLKIT for MNCC_BEARER_CAP_REQ
Mychaela Falconia <falcon@freecalypso.org>
parents: 155
diff changeset
34 CPPFLAGS="$CPPFLAGS -DSIM_TOOLKIT"
392
30203d5aeb74 components/*: -DCHIPSET=$CHIPSET instead of fixed -DCHIPSET=10
Mychaela Falconia <falcon@freecalypso.org>
parents: 305
diff changeset
35 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 392
diff changeset
36 CPPFLAGS="$CPPFLAGS -DBOARD=41"
155
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 # Includes
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 SRCDIR=$SRC/g23m-gsm/cc
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I.."
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -I../config"
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 # Source modules
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 cfile_str2ind $SRCDIR/cc_act.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 cfile_str2ind $SRCDIR/cc_cfk.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 cfile_str2ind $SRCDIR/cc_csf.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_str2ind $SRCDIR/cc_est.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 cfile_str2ind $SRCDIR/cc_ffk.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 cfile_str2ind $SRCDIR/cc_for.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 cfile_str2ind $SRCDIR/cc_pei.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 cfile_str2ind $SRCDIR/cc_rel.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 cfile_str2ind $SRCDIR/cc_srv.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 cfile_str2ind $SRCDIR/cc_time.c
6f5ebf4cd1b2 cc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 cfile_str2ind $SRCDIR/cc_em.c