annotate components/ccd_na7_db @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 9ffd8fd40afa
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
154
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building ccd_na7_db.lib using TCS3.2 CCD source
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mw -x -pw2 -me -mt -o -g -mn"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-DM_INTEL -DSHARED_VSI -DSHARED_CCD"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DCCDDATA_STATIC_DATA"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -D_TMS470 -DNEW_ENTITY -DERR_TRACE_CCD"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 # Includes
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/ccd"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc"
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 # Source modules
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 SRCDIR=$SRC/gpf3/ccd
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 cfile_plain $SRCDIR/ccd.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 cfile_plain $SRCDIR/bitfun.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 cfile_plain $SRCDIR/cdc_std.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 cfile_plain $SRCDIR/cdc_com.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 cfile_plain $SRCDIR/ccd_err.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 cfile_plain $SRCDIR/ccd_store.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 cfile_plain $SRCDIR/gsm1_tv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 cfile_plain $SRCDIR/gsm1_v.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 cfile_plain $SRCDIR/gsm2_t.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 cfile_plain $SRCDIR/gsm3_tv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 cfile_plain $SRCDIR/gsm3_v.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 cfile_plain $SRCDIR/gsm4_lv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 cfile_plain $SRCDIR/gsm4_tlv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 cfile_plain $SRCDIR/gsm5_tlv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 cfile_plain $SRCDIR/gsm5_tv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 cfile_plain $SRCDIR/gsm5_v.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 cfile_plain $SRCDIR/gsm6_tlv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 cfile_plain $SRCDIR/gsm7_lv.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 cfile_plain $SRCDIR/bcd_mnc.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 cfile_plain $SRCDIR/bcd_nofill.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 cfile_plain $SRCDIR/bcdeven.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 cfile_plain $SRCDIR/bcdodd.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 cfile_plain $SRCDIR/gsm1_asn.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 cfile_plain $SRCDIR/csn1_s1.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 cfile_plain $SRCDIR/csn1_sh.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 cfile_plain $SRCDIR/s_padding.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 cfile_plain $SRCDIR/t30_ident.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 cfile_plain $SRCDIR/asn1_bitstr.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 cfile_plain $SRCDIR/asn1_octet.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 cfile_plain $SRCDIR/asn1_integ.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 cfile_plain $SRCDIR/asn1_seq.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 cfile_plain $SRCDIR/asn1_choice.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 cfile_plain $SRCDIR/no_code.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 cfile_plain $SRCDIR/asn1_choice_ext.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_plain $SRCDIR/asn1_seq_ext.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 cfile_plain $SRCDIR/asn1_integ_ext.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 cfile_plain $SRCDIR/asn1_opentype.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 cfile_plain $SRCDIR/asn1_objid.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 cfile_plain $SRCDIR/noncritical_ext.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 cfile_plain $SRCDIR/critical_ext.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 cfile_plain $SRCDIR/ccd_elem.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 cfile_plain $SRCDIR/s_padding_0.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 cfile_plain $SRCDIR/csn1_s0.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 cfile_plain $SRCDIR/hl_flag.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 cfile_plain $SRCDIR/freq_list.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 cfile_plain $SRCDIR/fdd_ci.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 cfile_plain $SRCDIR/tdd_ci.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_plain $SRCDIR/freq_list_com.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_plain $SRCDIR/csn1_concat.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_plain $SRCDIR/break_cond.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_plain $SRCDIR/csn1_sx.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 cfile_plain $SRCDIR/csn1_choice_1.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 cfile_plain $SRCDIR/csn1_choice_2.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 cfile_plain $SRCDIR/csn1_choice_x.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 cfile_plain $SRCDIR/csn1_sh_opt.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 cfile_plain $SRCDIR/csn1_s1_opt.c
9ffd8fd40afa ccd_na7_db.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_plain $SRCDIR/csn1_s0_opt.c