annotate components/cci @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
184
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building cci.lib from the TCS3.2 source
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DGPRS"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 if [ "$SRVC" != 0 ]
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 then
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 if [ "$SRVC" = 1 ]
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 then
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DFF_FAX"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 fi
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 fi
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 if [ "$MMI" = 0 ]
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 then
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DACI"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 elif [ "$MMI" = 2 ]
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 then
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -DMFW"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 fi
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DLL_DESC"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -DCCI_FLASH_ROM"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 184
diff changeset
51 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 184
diff changeset
52 CPPFLAGS="$CPPFLAGS -DBOARD=41"
184
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 # Includes
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-gprs/llc"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/g23m-gprs/cci"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I.."
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I../config"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 # Source modules
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 SRCDIR=$SRC/g23m-gprs/cci
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 cfile_str2ind $SRCDIR/cci_gea_start.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 cfile_str2ind $SRCDIR/cci_fbsf.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 #cfile_str2ind $SRCDIR/cci_fbsp.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 cfile_str2ind $SRCDIR/cci_fbss.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 cfile_str2ind $SRCDIR/cci_hw_sim.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 cfile_str2ind $SRCDIR/cci_qf.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 cfile_str2ind $SRCDIR/cci_qp.c
39a713b2130c cci.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/cci_qs.c