annotate components/cl @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
204
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building cl.lib from the TCS3.2 source
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 if [ "$SRVC" != 0 ]
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 then
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$SRVC" = 1 ]
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DFF_FAX"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 fi
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$MMI" = 0 ]
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DACI"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 elif [ "$MMI" = 2 ]
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 then
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DMFW"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 fi
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DGPRS"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 204
diff changeset
49 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 204
diff changeset
50 CPPFLAGS="$CPPFLAGS -DBOARD=41"
204
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 # Includes
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 SRCDIR=$SRC/g23m-gprs/cl
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I.."
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I../config"
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 # Source modules
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 cfile_str2ind $SRCDIR/cl_nwrl.c
e2714de970a4 TCS2/TCS3 hybrid config links after adding cl.lib
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/clqos.c