annotate components/comlib @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 53232836b105
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
25
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building comlib.lib
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DCL_IMEI_CALYPSO_PLATFORM"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 # Includes
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I.."
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I../config"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 # Source modules
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 SRCDIR=$SRC/condat2/com/src/comlib
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 if [ "$SRVC" != 0 ]
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 then
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 cfile_str2ind $SRCDIR/cl_ribu.c
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 fi
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 if [ "$GPRS" = 1 ]
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 then
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 cfile_str2ind $SRCDIR/cl_rlcmac.c
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 fi
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 cfile_str2ind $SRCDIR/cl_md5.c
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/cl_imei.c
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_str2ind $SRCDIR/cl_des.c
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/cl_shrd.c
53232836b105 comlib.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/cl_list.c