annotate components/config_gprs_fl @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents f26b5c2bf806
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
23
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building config_gprs_fl.lib
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DGPRS"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 if [ "$SRVC" != 0 ]
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 then
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 if [ "$SRVC" = 1 ]
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 then
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -DFF_FAX"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 fi
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 fi
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 if [ "$MMI" = 0 ]
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 then
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -DACI"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 elif [ "$MMI" = 2 ]
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 then
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DMFW"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 fi
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DCONFIG_MODULE"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DNU_DEBUG"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -DPRIM_0_INT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DPRIM_1_INT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -DPRIM_2_INT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -DPRIM_3_INT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -DPRIM_4_INT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -DPRIM_5_INT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -DBOARD=41"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -DCTRACE"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -DDATA_EXT_RAM"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 # Includes
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc/arm7"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/condat2/frame/config"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I.."
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I../config"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 # Source modules
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 SRCDIR=$SRC/condat2/frame/config
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/gprscomp.c
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 cfile_str2ind $SRCDIR/custcomp.c
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 cfile_str2ind $SRCDIR/gprsinit.c
f26b5c2bf806 config_gprs_fl.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 cfile_str2ind $SRCDIR/gprsdrv.c