annotate components/config_gprs_ir @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 1437de40b0c5
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
24
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building config_gprs_ir.lib
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DGPRS"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 if [ "$SRVC" != 0 ]
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 then
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 if [ "$SRVC" = 1 ]
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 then
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -DFF_FAX"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 fi
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 fi
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 if [ "$MMI" = 0 ]
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 then
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -DACI"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 elif [ "$MMI" = 2 ]
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 then
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DMFW"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 fi
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DCONFIG_MODULE"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DNU_DEBUG"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -DPRIM_0_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DPRIM_1_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -DPRIM_2_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -DPRIM_3_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -DPRIM_4_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -DPRIM_5_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -DBOARD=41"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -DCTRACE"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -DDATA_INT_RAM"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 # Includes
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc/arm7"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/condat2/frame/config"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I.."
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I../config"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 # Source modules
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 SRCDIR=$SRC/condat2/frame/config
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95
1437de40b0c5 config_gprs_ir.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/gprscomp.c