annotate components/config_gsm_fl @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 6b8e432a8cd9
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
351
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building config_gsm_fl.lib
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 if [ "$SRVC" != 0 ]
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 then
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$SRVC" = 1 ]
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DFF_FAX"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 fi
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$MMI" = 0 ]
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DACI"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 elif [ "$MMI" = 2 ]
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 then
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DMFW"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 fi
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DCONFIG_MODULE"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DNU_DEBUG"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DPRIM_0_INT_RAM"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -DPRIM_1_INT_RAM"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -DPRIM_2_INT_RAM"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -DPRIM_3_INT_RAM"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -DPRIM_4_INT_RAM"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -DPRIM_5_INT_RAM"
358
6b8e432a8cd9 !GPRS configs: TEST and DMEM pools moved into IRAM
Mychaela Falconia <falcon@freecalypso.org>
parents: 351
diff changeset
55 CPPFLAGS="$CPPFLAGS -DTEST_0_INT_RAM"
6b8e432a8cd9 !GPRS configs: TEST and DMEM pools moved into IRAM
Mychaela Falconia <falcon@freecalypso.org>
parents: 351
diff changeset
56 CPPFLAGS="$CPPFLAGS -DTEST_1_INT_RAM"
6b8e432a8cd9 !GPRS configs: TEST and DMEM pools moved into IRAM
Mychaela Falconia <falcon@freecalypso.org>
parents: 351
diff changeset
57 CPPFLAGS="$CPPFLAGS -DTEST_2_INT_RAM"
6b8e432a8cd9 !GPRS configs: TEST and DMEM pools moved into IRAM
Mychaela Falconia <falcon@freecalypso.org>
parents: 351
diff changeset
58 CPPFLAGS="$CPPFLAGS -DDMEM_0_INT_RAM"
351
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -DBOARD=41"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -DCTRACE"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -DDATA_EXT_RAM"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 # Includes
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc/arm7"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/condat2/com/src/config"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I.."
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I../config"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 # Source modules
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 SRCDIR=$SRC/condat2/com/src/config
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 cfile_str2ind $SRCDIR/gsmcomp.c
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 cfile_str2ind $SRCDIR/custcomp.c
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
101 cfile_str2ind $SRCDIR/gsminit.c
353514087133 components/config_gsm_{fl,ir}: created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102 cfile_str2ind $SRCDIR/gsmdrv.c