annotate components/drivers_flash @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c39e9d96c464
children 0cbe7438f974
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
27
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building drivers_flash.lib
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -pw2 -mn -x -mt -o2 -mw"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 # Includes
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -I../config"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -I.."
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_cust0"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_include"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/cust0"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/hmacs"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/p_include"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_include"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_cust0"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/dyn_dwl_include"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/p_source0"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source0"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 SRCDIR=$SRC/cs/drivers/drv_core
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 # 1st set of source modules
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 cfile_plain $SRCDIR/dsp_dwnld/leadapi.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 cfile_plain $SRCDIR/inth/niq.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 cfile_plain $SRCDIR/uart/uart.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 cfile_plain $SRCDIR/inth/inth.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 cfile_plain $SRCDIR/timer/timer.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 cfile_plain $SRCDIR/timer/timer1.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 cfile_plain $SRCDIR/timer/timer2.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 cfile_plain $SRCDIR/timer/timer_sec.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_plain $SRCDIR/security/certificate.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 cfile_plain $SRCDIR/clkm/clkm.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 cfile_plain $SRCDIR/armio/armio.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 # 2nd set of source modules
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CFLAGS="-me -pw2 -mn -mt"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 cfile_plain $SRCDIR/spi/spi_drv.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 cfile_plain $SRCDIR/abb/abb.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 cfile_plain $SRCDIR/abb/abb_core_inth.c
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 # niq32
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CFLAGS="-me -pw2 -x -o -mw"
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70
c39e9d96c464 drivers_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_plain $SRCDIR/inth/niq32.c