annotate components/dti @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
171
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building dti.lib from the TCS3.2 source
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version dti
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain dti_version.c
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$MMI" = 0 ]
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DACI"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 elif [ "$MMI" = 2 ]
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 then
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DMFW"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 fi
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DDTI2"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 if [ "$GPRS" = 1 ]
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 then
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -DGPRS"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 fi
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 172
diff changeset
45 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 172
diff changeset
46 CPPFLAGS="$CPPFLAGS -DBOARD=41"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 172
diff changeset
47
171
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 # Includes
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 SRCDIR=$SRC/g23m-aci/dti
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
172
2c61607bb3e3 build system: pass ACI version for headers to the component recipes
Mychaela Falconia <falcon@freecalypso.org>
parents: 171
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$ACI/aci_dti_mng"
171
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I.."
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I../config"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 # Source modules
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 cfile_str2ind $SRCDIR/dti_kerf.c
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 cfile_str2ind $SRCDIR/dti_kerp.c
a8efe285e7fa dti.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 cfile_str2ind $SRCDIR/dti_int.c