annotate components/fad @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
175
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building fad.lib from the TCS3.2 source
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version fad
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain fad_version.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$MMI" = 0 ]
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DACI"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 elif [ "$MMI" = 2 ]
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 then
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DMFW"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 fi
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$GPRS" = 1 ]
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DGPRS"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 fi
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DFF_FAX"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DSRVC=1"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 175
diff changeset
50 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 175
diff changeset
51 CPPFLAGS="$CPPFLAGS -DBOARD=41"
175
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 # Includes
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 SRCDIR=$SRC/g23m-fad/fad
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I.."
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I../config"
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 # Source modules
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 cfile_str2ind $SRCDIR/fad_kerf.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/fad_kerp.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_str2ind $SRCDIR/fad_kers.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/fad_pei.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/fad_rbm.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 cfile_str2ind $SRCDIR/fad_rcvf.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 cfile_str2ind $SRCDIR/fad_rcvp.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 cfile_str2ind $SRCDIR/fad_rcvs.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 cfile_str2ind $SRCDIR/fad_sbm.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 cfile_str2ind $SRCDIR/fad_sndf.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_str2ind $SRCDIR/fad_sndp.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 cfile_str2ind $SRCDIR/fad_snds.c
bca0f7237ecd fad.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 cfile_str2ind $SRCDIR/fad_tim.c