annotate components/fchg @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 1c711302732a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
323
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building FCHG SWE - an original FreeCalypso addition
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -o -x -mw -me -pw2"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 # Includes
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -I.."
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -I../config"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 # Source modules
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 SRCDIR=$SRC/cs/drivers/drv_app/fchg
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
336
be011556e71f FCHG: API implementation started
Mychaela Falconia <falcon@freecalypso.org>
parents: 331
diff changeset
38 cfile_plain $SRCDIR/fchg_api.c
324
6ab14029931c FCHG: default battery table implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 323
diff changeset
39 cfile_plain $SRCDIR/fchg_default_batt.c
323
f08212cf0b04 components/fchg compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 cfile_plain $SRCDIR/fchg_env.c
325
ab47ade99fa9 FCHG: reading of charging config from FFS implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 324
diff changeset
41 cfile_plain $SRCDIR/fchg_ffs_init.c
338
1c711302732a FCHG: complete enough to attempt linking into fw build
Mychaela Falconia <falcon@freecalypso.org>
parents: 337
diff changeset
42 cfile_plain $SRCDIR/fchg_messages.c
331
8166b0afcf8c FCHG: main ADC process implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 325
diff changeset
43 cfile_plain $SRCDIR/fchg_process.c
337
0df0668f8bea FCHG: task core function implemented
Mychaela Falconia <falcon@freecalypso.org>
parents: 336
diff changeset
44 cfile_plain $SRCDIR/fchg_task.c