annotate components/ffs @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents d5f08174ee4f
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
42
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building ffs.lib
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -o -x -mw -me -pw2"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-DWITH_TFFS=0 -DTMFFS2"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 if [ "$SRVC" != 0 ]
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 then
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA=FAX_AND_DATA"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 fi
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DTOOL_CHOICE=0 -D_TMS470"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 # Includes
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I.."
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I../config"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 # Source modules
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 SRCDIR=$SRC/cs/drivers/drv_app/ffs/board
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 cfile_plain $SRCDIR/amdsbdrv.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 cfile_plain $SRCDIR/core.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 cfile_plain $SRCDIR/drv.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 cfile_plain $SRCDIR/ffstrace.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 cfile_plain $SRCDIR/fsck.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 cfile_plain $SRCDIR/intelsbdrv.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 cfile_plain $SRCDIR/reclaim.c
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 # ffs_target.c generation
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 helpers/makeline dep ffs_target.c $SRCDIR/ffs.c $SRCDIR/mktarget.pl \
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 >> $BUILD_DIR/$LIBNAME/Makefile
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 helpers/makeline cmd perl -w $SRCDIR/mktarget.pl $SRCDIR . \
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 >> $BUILD_DIR/$LIBNAME/Makefile
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 echo >> $BUILD_DIR/$LIBNAME/Makefile
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61
d5f08174ee4f ffs.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 cfile_plain ffs_target.c