annotate components/ffs_drv @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3afde7cb1786
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
43
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building ffs_drv.lib
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -o -x -mw -me -pw2"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-DWITH_TFFS=0 -DTMFFS2"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 if [ "$SRVC" != 0 ]
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 then
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA=FAX_AND_DATA"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 fi
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DTOOL_CHOICE=0 -D_TMS470"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 # Includes
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I.."
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I../config"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_cust0"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_include"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/cust0"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/hmacs"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/p_include"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_include"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_cust0"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/dyn_dwl_include"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 # Source modules
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 SRCDIR=$SRC/cs/drivers/drv_app/ffs/board
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_plain $SRCDIR/cfgffs.c
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 cfile_plain $SRCDIR/dev.c
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 cfile_plain $SRCDIR/pcmcode.c
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 cfile_plain $SRCDIR/task.c
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 cfile_plain $SRCDIR/tmffs.c
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 # Different CFLAGS and CPPFLAGS for ffs_env.c
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CFLAGS="-mn -mt -me -pw2"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 # Includes
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I.."
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I../config"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93
3afde7cb1786 ffs_drv.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 cfile_plain $SRCDIR/ffs_env.c