annotate components/ffs_pcm @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents fa7a021e95c5
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
44
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building ffs_pcm.lib
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -o -x -mw -me -pw2"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 if [ "$SRVC" != 0 ]
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 then
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA=FAX_AND_DATA"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 fi
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 # Includes
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I.."
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I../config"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 # Source modules
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 SRCDIR=$SRC/cs/drivers/drv_app/ffs/board
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44
fa7a021e95c5 ffs_pcm.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 cfile_plain $SRCDIR/pcmdata.c