annotate components/gmm @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
186
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building gmm.lib from the TCS3.2 source
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if [ "$MMI" = 0 ]
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 then
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DACI"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 elif [ "$MMI" = 2 ]
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 then
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DMFW"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 fi
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DGPRS"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 if [ "$SRVC" != 0 ]
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 then
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 if [ "$SRVC" = 1 ]
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 then
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DFF_FAX"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 fi
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 fi
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 186
diff changeset
49 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 186
diff changeset
50 CPPFLAGS="$CPPFLAGS -DBOARD=41"
186
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 # Includes
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 SRCDIR=$SRC/g23m-gprs/gmm
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/$ACI/aci"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I.."
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I../config"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 # Source modules
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 cfile_str2ind $SRCDIR/gmm_f.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 cfile_str2ind $SRCDIR/gmm_pei.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 cfile_str2ind $SRCDIR/gmm_kernf.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 cfile_str2ind $SRCDIR/gmm_kernl.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 cfile_str2ind $SRCDIR/gmm_kernp.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 cfile_str2ind $SRCDIR/gmm_kerns.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 cfile_str2ind $SRCDIR/gmm_txf.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 cfile_str2ind $SRCDIR/gmm_txp.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/gmm_txs.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 cfile_str2ind $SRCDIR/gmm_rxf.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 cfile_str2ind $SRCDIR/gmm_rxp.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 cfile_str2ind $SRCDIR/gmm_rxs.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 cfile_str2ind $SRCDIR/gmm_rdyf.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
101 cfile_str2ind $SRCDIR/gmm_rdyp.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102 cfile_str2ind $SRCDIR/gmm_rdys.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
103 cfile_str2ind $SRCDIR/gmm_syncf.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
104 cfile_str2ind $SRCDIR/gmm_syncp.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
105 cfile_str2ind $SRCDIR/gmm_syncs.c
ad246f580a30 components/gmm: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
106 cfile_str2ind $SRCDIR/gmm_em.c