annotate components/grlc @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
188
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building grlc.lib from the TCS3.2 source
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if [ "$MMI" = 0 ]
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 then
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DACI"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 elif [ "$MMI" = 2 ]
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 then
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DMFW"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 fi
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DGPRS"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 if [ "$SRVC" != 0 ]
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 then
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 if [ "$SRVC" = 1 ]
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 then
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DFF_FAX"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 fi
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 fi
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DTRACE_FKT"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 188
diff changeset
50 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 188
diff changeset
51 CPPFLAGS="$CPPFLAGS -DBOARD=41"
188
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 # Includes
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 SRCDIR=$SRC/g23m-gprs/grlc
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I.."
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I../config"
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 # Source modules
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/grlc_f.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_str2ind $SRCDIR/grlc_gfff.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/grlc_gffp.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/grlc_gffs.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 cfile_str2ind $SRCDIR/grlc_measf.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 cfile_str2ind $SRCDIR/grlc_measp.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 cfile_str2ind $SRCDIR/grlc_meass.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 cfile_str2ind $SRCDIR/grlc_pei.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 cfile_str2ind $SRCDIR/grlc_rdf.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_str2ind $SRCDIR/grlc_rdp.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 cfile_str2ind $SRCDIR/grlc_rds.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 cfile_str2ind $SRCDIR/grlc_ruf.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 cfile_str2ind $SRCDIR/grlc_rup.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 cfile_str2ind $SRCDIR/grlc_rus.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 cfile_str2ind $SRCDIR/grlc_tmf.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 cfile_str2ind $SRCDIR/grlc_tmp.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 cfile_str2ind $SRCDIR/grlc_tms.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 cfile_str2ind $SRCDIR/grlc_tpcg.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 cfile_str2ind $SRCDIR/grlc_tpcs.c
c08123e14970 grlc.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 cfile_str2ind $SRCDIR/grlc_em.c