annotate components/grr @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
190
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building grr.lib from the TCS3.2 source
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if [ "$MMI" = 0 ]
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 then
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DACI"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 elif [ "$MMI" = 2 ]
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 then
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DMFW"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 fi
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DGPRS"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 if [ "$SRVC" != 0 ]
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 then
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 if [ "$SRVC" = 1 ]
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 then
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DFF_FAX"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 fi
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 fi
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DTRACE_FKT"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 190
diff changeset
50 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 190
diff changeset
51 CPPFLAGS="$CPPFLAGS -DBOARD=41"
190
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 # Includes
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 SRCDIR=$SRC/g23m-gprs/grr
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I.."
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I../config"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 # Source modules
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 cfile_str2ind $SRCDIR/grr_cpapf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 cfile_str2ind $SRCDIR/grr_cpapp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 cfile_str2ind $SRCDIR/grr_cpaps.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 cfile_str2ind $SRCDIR/grr_csf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 cfile_str2ind $SRCDIR/grr_csp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 cfile_str2ind $SRCDIR/grr_css.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 cfile_str2ind $SRCDIR/grr_ctrlf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 cfile_str2ind $SRCDIR/grr_ctrlp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/grr_ctrls.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 cfile_str2ind $SRCDIR/grr_em.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 cfile_str2ind $SRCDIR/grr_f.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 cfile_str2ind $SRCDIR/grr_gfpf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 cfile_str2ind $SRCDIR/grr_gfpp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
101 cfile_str2ind $SRCDIR/grr_meass.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102 cfile_str2ind $SRCDIR/grr_measp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
103 cfile_str2ind $SRCDIR/grr_measf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
104 cfile_str2ind $SRCDIR/grr_pei.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
105 cfile_str2ind $SRCDIR/grr_pgf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
106 cfile_str2ind $SRCDIR/grr_pgp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
107 cfile_str2ind $SRCDIR/grr_pgs.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
108 cfile_str2ind $SRCDIR/grr_psif.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
109 cfile_str2ind $SRCDIR/grr_psip.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
110 cfile_str2ind $SRCDIR/grr_psis.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
111 cfile_str2ind $SRCDIR/grr_tcf.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
112 cfile_str2ind $SRCDIR/grr_tcp.c
1bb891186358 components/grr: recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
113 cfile_str2ind $SRCDIR/grr_tcs.c