annotate components/l1_custom_int @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 7129e312b2ab
children 838eeafb0051
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
230
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building l1_custom_int.lib
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-g -me -pw2 -mt -o -mw"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DRV_TRACE_LEVEL_WARNING=2 -DTOOL_CHOICE=0 -D_TMS470"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 # Includes
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -I../config"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -I.."
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app/buzzer"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app/ffs"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app/sim"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app/uart"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rvt"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services/Audio"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_cust0"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_include"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/cust0"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/hmacs"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/p_include"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_include"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_cust0"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/dyn_dwl_include"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/p_source0"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source0"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 # Source modules
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 SRCDIR=$SRC/cs/layer1
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_plain $SRCDIR/cust0/l1_cust.c
7129e312b2ab l1_custom_int.lib rebuilt from source for the l1reconst config
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 cfile_plain $SRCDIR/cust0/ind_os.c