annotate components/l1_pei @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 72b8a6a15d46
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
106
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building l1_pei.lib
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version l1 l1_pei
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain l1_pei_version.c
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$GPRS" = 1 ]
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DGPRS"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DALR=1"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DNCONF"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DNTRACE"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 # Includes
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 SRCDIR=$SRC/g23m-gsm/l1
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 # Source modules
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
72b8a6a15d46 components/l1_pei: recipe created, compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 cfile_str2ind $SRCDIR/l1_pei.c