annotate components/l2r @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
176
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building l2r.lib from the TCS3.2 source
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version l2r
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain l2r_version.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$GPRS" = 1 ]
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DGPRS"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 if [ "$SRVC" = 1 ]
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 then
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DFF_FAX"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 fi
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DDTI2"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 176
diff changeset
46 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 176
diff changeset
47 CPPFLAGS="$CPPFLAGS -DBOARD=41"
176
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 # Includes
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 SRCDIR=$SRC/g23m-fad/l2r
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I.."
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I../config"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 # Source modules
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 cfile_str2ind $SRCDIR/l2r_dnf.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 cfile_str2ind $SRCDIR/l2r_dnp.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 cfile_str2ind $SRCDIR/l2r_dns.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 cfile_str2ind $SRCDIR/l2r_mgtf.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 cfile_str2ind $SRCDIR/l2r_mgtp.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 cfile_str2ind $SRCDIR/l2r_mgts.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 cfile_str2ind $SRCDIR/l2r_pei.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 cfile_str2ind $SRCDIR/l2r_ups.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 cfile_str2ind $SRCDIR/l2r_tim.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 cfile_str2ind $SRCDIR/l2r_upf.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93 cfile_str2ind $SRCDIR/l2r_upp.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 cfile_str2ind $SRCDIR/tra_mgts.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95 cfile_str2ind $SRCDIR/tra_mgtf.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/tra_mgtp.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 cfile_str2ind $SRCDIR/tra_dns.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 cfile_str2ind $SRCDIR/tra_dnf.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 cfile_str2ind $SRCDIR/tra_dnp.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 cfile_str2ind $SRCDIR/tra_ups.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
101 cfile_str2ind $SRCDIR/tra_upf.c
3979a1edb59e l2r.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102 cfile_str2ind $SRCDIR/tra_upp.c