annotate components/main @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 30203d5aeb74
children 838eeafb0051
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
102
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building main.lib
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 OBJS="../../$INIT_blob"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # C modules
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CFLAGS="-mn -mt -o -x -mw -me -pw2"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 # Includes
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I.."
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I../config"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_cust0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_include"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/cust0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/hmacs"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/p_include"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_include"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_cust0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/dyn_dwl_include"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/p_source0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 SRCDIR=$SRC/cs/system/Main
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 cfile_plain $SRCDIR/create_RVtasks.c
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 cfile_plain $SRCDIR/main.c
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 cfile_plain $SRCDIR/sys_dummy.c
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 OBJS="$OBJS ../../blobs/obj/main/mem_load.obj"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 # Assembly module
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 ASMFLAGS=-me
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 ASMFLAGS="$ASMFLAGS -dBOARD=41"
392
30203d5aeb74 components/*: -DCHIPSET=$CHIPSET instead of fixed -DCHIPSET=10
Mychaela Falconia <falcon@freecalypso.org>
parents: 102
diff changeset
62 ASMFLAGS="$ASMFLAGS -dCHIPSET=$CHIPSET"
102
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 ASMFLAGS="$ASMFLAGS -dLONG_JUMP=3"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 ASMFLAGS="$ASMFLAGS -dTOOL_CHOICE=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 ASMFLAGS="$ASMFLAGS -dR2D_ASM=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 ASMFLAGS="$ASMFLAGS -dR2D_LCD_TEST=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 ASMFLAGS="$ASMFLAGS -dTI_PROFILER=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 ASMFLAGS="$ASMFLAGS -dTI_NUC_MONITOR=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 ASMFLAGS="$ASMFLAGS -dL1_GPRS=$GPRS"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 ASMFLAGS="$ASMFLAGS -dOP_WCP=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 ASMFLAGS="$ASMFLAGS -dWCP_PROF=0"
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72
455ac12899fd main.lib rebuilt from source except for init.obj and mem_load.obj
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 asm_file $SRCDIR/int.s