annotate components/main-init @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 30203d5aeb74
children 838eeafb0051
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
266
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building main.lib with recompilation of the init module
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 # C modules
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 CFLAGS="-mn -mt -o -x -mw -me -pw2"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
378
aee911923299 components/*: support for c11x target
Mychaela Falconia <falcon@freecalypso.org>
parents: 282
diff changeset
8 if [ "$TARGET" = c139 -o "$TARGET" = c11x ]
273
8fb920215a46 init.c & components/main-init: put RVTMUX on MODEM on C139 like before
Mychaela Falconia <falcon@freecalypso.org>
parents: 266
diff changeset
9 then
8fb920215a46 init.c & components/main-init: put RVTMUX on MODEM on C139 like before
Mychaela Falconia <falcon@freecalypso.org>
parents: 266
diff changeset
10 CPPFLAGS="$CPPFLAGS -DCONFIG_RVTMUX_ON_MODEM"
8fb920215a46 init.c & components/main-init: put RVTMUX on MODEM on C139 like before
Mychaela Falconia <falcon@freecalypso.org>
parents: 266
diff changeset
11 fi
8fb920215a46 init.c & components/main-init: put RVTMUX on MODEM on C139 like before
Mychaela Falconia <falcon@freecalypso.org>
parents: 266
diff changeset
12
266
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 # Includes
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I.."
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I../config"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_cust0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/audio_include"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/cust0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/hmacs"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/p_include"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_include"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tm_cust0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/dyn_dwl_include"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/p_source0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/tpu_drivers/source"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 SRCDIR=$SRC/cs/system/Main
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_plain $SRCDIR/init.c
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 cfile_plain $SRCDIR/create_RVtasks.c
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 cfile_plain $SRCDIR/main.c
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 cfile_plain $SRCDIR/sys_dummy.c
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59
282
50fa2f79c1d4 components/main-init: recompile mem_load.obj from mem_load.c
Mychaela Falconia <falcon@freecalypso.org>
parents: 273
diff changeset
60 # Different CFLAGS for mem_load.c
50fa2f79c1d4 components/main-init: recompile mem_load.obj from mem_load.c
Mychaela Falconia <falcon@freecalypso.org>
parents: 273
diff changeset
61
50fa2f79c1d4 components/main-init: recompile mem_load.obj from mem_load.c
Mychaela Falconia <falcon@freecalypso.org>
parents: 273
diff changeset
62 CFLAGS="-o -mw -me -pw2"
50fa2f79c1d4 components/main-init: recompile mem_load.obj from mem_load.c
Mychaela Falconia <falcon@freecalypso.org>
parents: 273
diff changeset
63
50fa2f79c1d4 components/main-init: recompile mem_load.obj from mem_load.c
Mychaela Falconia <falcon@freecalypso.org>
parents: 273
diff changeset
64 cfile_plain $SRCDIR/mem_load.c
266
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 # Assembly module
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 ASMFLAGS=-me
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 ASMFLAGS="$ASMFLAGS -dBOARD=41"
392
30203d5aeb74 components/*: -DCHIPSET=$CHIPSET instead of fixed -DCHIPSET=10
Mychaela Falconia <falcon@freecalypso.org>
parents: 378
diff changeset
70 ASMFLAGS="$ASMFLAGS -dCHIPSET=$CHIPSET"
266
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 ASMFLAGS="$ASMFLAGS -dLONG_JUMP=3"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 ASMFLAGS="$ASMFLAGS -dTOOL_CHOICE=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 ASMFLAGS="$ASMFLAGS -dR2D_ASM=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 ASMFLAGS="$ASMFLAGS -dR2D_LCD_TEST=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 ASMFLAGS="$ASMFLAGS -dTI_PROFILER=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 ASMFLAGS="$ASMFLAGS -dTI_NUC_MONITOR=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 ASMFLAGS="$ASMFLAGS -dL1_GPRS=$GPRS"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 ASMFLAGS="$ASMFLAGS -dOP_WCP=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 ASMFLAGS="$ASMFLAGS -dWCP_PROF=0"
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80
692f565226ef components/main-init compilation recipe created
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 asm_file $SRCDIR/int.s