annotate components/misc_na7_db_ir @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents b257154f1406
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
298
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building misc_na7_db_ir.lib using the GPF source bits we got with TCS211
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mw -x -pw2 -o -me -mt -g -mn"
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-D_TARGET_ -D_NUCLEUS_ -DRUN_INT_RAM"
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Includes
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I$SRC/gpf2/misc"
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc"
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc/nuc/arm7"
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 # Source modules
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 SRCDIR=$SRC/gpf2/misc
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 cfile_plain $SRCDIR/printtofile.c
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 cfile_plain $SRCDIR/tok.c
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 cfile_plain $SRCDIR/tools.c
b257154f1406 components/misc_na7_db_{fl,ir}: compiling, perfect match to original blobs
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 cfile_plain $SRCDIR/misc_version.c