annotate components/power @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 472fba6e92b7
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
47
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building power.lib
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -o -x -mw -me -pw2"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470 -DMMI=$MMI"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 if [ "$MMI" = 0 ]
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 then
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DACI"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 elif [ "$MMI" = 2 ]
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 then
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -DMFW"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 fi
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 # Includes
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I.."
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I../config"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 # Source modules
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 SRCDIR=$SRC/cs/drivers/drv_app/power
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45
472fba6e92b7 power.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 cfile_plain $SRCDIR/board/power.c