annotate components/ppp_ir @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
182
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building ppp_ir.lib from the TCS3.2 source
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if [ "$GPRS" = 1 ]
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 then
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DGPRS"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 fi
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 if [ "$SRVC" != 0 ]
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 then
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 if [ "$SRVC" = 1 ]
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 then
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DFF_FAX"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 fi
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 fi
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DDTI2"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DDTILIB"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -DPPP_INT_RAM"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 182
diff changeset
47 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 182
diff changeset
48 CPPFLAGS="$CPPFLAGS -DBOARD=41"
182
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 # Includes
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 SRCDIR=$SRC/g23m-fad/ppp
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I.."
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I../config"
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 # Source modules
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 cfile_str2ind $SRCDIR/ppp_frxf.c
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 cfile_str2ind $SRCDIR/ppp_ftxf.c
f02d0a0e1849 ppp_ir.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 cfile_str2ind $SRCDIR/ppp_tbls.c