annotate components/r2d_drv_int_ram @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 9737224b10e1
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
118
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building r2d_drv_int_ram.lib
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mf -o2 -mw -me -pw2"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 # Includes
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -I.."
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -I../config"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 # Source modules
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 SRCDIR=$SRC/cs/drivers/drv_app/r2d
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 cfile_plain $SRCDIR/r2d_lcd_geometry.c
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 cfile_plain $SRCDIR/r2d_lcds.c
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 cfile_plain $SRCDIR/r2d_refresh.c
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 # New sourceset
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CFLAGS="-mn -mw -me -pw2"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 # Includes
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 CPPFLAGS="$CPPFLAGS -I.."
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -I../config"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 # Source modules
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_plain $SRCDIR/lcds/r2d_geometry_no2_lcd_i.c
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 # TCS211 build system includes 3 assembly modules at this point,
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 # but we are omitting them because they are disabled by the
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 # R2D_ASM=0 setting in the very same TCS211 reference version,
9737224b10e1 r2d_drv_int_ram.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 # i.e., they assemble to empty objects.