annotate components/riviera_cust_flash @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents aee911923299
children bb9a08797022
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
29
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building riviera_cust_flash.lib
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mn -mt -me -pw2"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS="-DTOOL_CHOICE=0 -D_TMS470"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
319
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
6 if [ "$MMI" = 0 ]
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
7 then
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
8 case "$TARGET" in
378
aee911923299 components/*: support for c11x target
Mychaela Falconia <falcon@freecalypso.org>
parents: 319
diff changeset
9 c11x|c139)
319
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
10 CPPFLAGS="$CPPFLAGS -DPSEUDO_MODEM_KEEPALIVE"
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
11 ;;
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
12 pirelli)
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
13 CPPFLAGS="$CPPFLAGS -DPSEUDO_MODEM_KEEPALIVE"
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
14 CPPFLAGS="$CPPFLAGS -DPSEUDO_MODEM_USB"
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
15 ;;
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
16 esac
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
17 fi
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
18
29
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 # Includes
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -I$SRC/cs/os/nucleus"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -I.."
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -I../config"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/frame/cust_os"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera/rv"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 # Source modules
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 SRCDIR=$SRC/cs/riviera
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 cfile_plain $SRCDIR/rvf/rvf_mem_pool.c
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 cfile_plain $SRCDIR/rvm/rvm_swe.c
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 cfile_plain $SRCDIR/rvt/rvt_api.c
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 cfile_plain $SRCDIR/rvt/rvt_env.c
036e8f92c158 riviera_cust_flash.lib done
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 cfile_plain $SRCDIR/rvt/rvt_task.c
319
9ffdfacfe969 implemented pseudo-modem keepalive for C139 and Pirelli targets
Mychaela Falconia <falcon@freecalypso.org>
parents: 29
diff changeset
56 cfile_plain $SRCDIR/rvt/rvt_keepalive.c