annotate components/rr @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
158
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building rr.lib from the TCS3.2 source
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 CPPFLAGS=
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 make_version rr
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 cfile_plain rr_version.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Defines
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS=-DCCDTABLES_EXTERN
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -D_TARGET_"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DALR"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -D_TMS470"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DUART"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DFF_ATI"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 CPPFLAGS="$CPPFLAGS -DNWARN"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$MMI" = 0 ]
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DACI"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 elif [ "$MMI" = 2 ]
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 then
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 CPPFLAGS="$CPPFLAGS -DMFW"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 fi
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$GPRS" = 1 ]
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DGPRS"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 fi
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 if [ "$SRVC" != 0 ]
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 then
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
50 if [ "$SRVC" = 1 ]
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
51 then
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52 CPPFLAGS="$CPPFLAGS -DFF_FAX"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 fi
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 fi
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 158
diff changeset
58 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 158
diff changeset
59 CPPFLAGS="$CPPFLAGS -DBOARD=41"
158
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 # Includes
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 SRCDIR=$SRC/g23m-gsm/rr
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 CPPFLAGS="$CPPFLAGS -I.."
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 CPPFLAGS="$CPPFLAGS -I../config"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 CPPFLAGS="$CPPFLAGS -I$SRC/cs/riviera"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_app"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/abb"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/armio"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/clkm"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/conf"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dma"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/dsp_dwnld"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/inth"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/memif"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/rhea"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
85 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/security"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
86 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/spi"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
87 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/timer"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
88 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/uart"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
89 CPPFLAGS="$CPPFLAGS -I$SRC/cs/drivers/drv_core/ulpd"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
90 CPPFLAGS="$CPPFLAGS -I$SRC/cs/system"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
91 CPPFLAGS="$CPPFLAGS -I$SRC/cs/layer1/include"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
92 CPPFLAGS="$CPPFLAGS -I$SRC/cs/services"
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
93
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
94 # Source modules
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
95
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
96 cfile_str2ind $SRCDIR/rr_attf.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
97 cfile_str2ind $SRCDIR/rr_attp.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
98 cfile_str2ind $SRCDIR/rr_atts.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
99 cfile_str2ind $SRCDIR/rr_datf.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
100 cfile_str2ind $SRCDIR/rr_datp.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
101 cfile_str2ind $SRCDIR/rr_dats.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
102 cfile_str2ind $SRCDIR/rr_forf.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
103 cfile_str2ind $SRCDIR/rr_forp.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
104 cfile_str2ind $SRCDIR/rr_fors.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
105 cfile_str2ind $SRCDIR/rr_csf.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
106 cfile_str2ind $SRCDIR/rr_pei.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
107 cfile_str2ind $SRCDIR/rr_srv.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
108 cfile_str2ind $SRCDIR/rr_tim.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
109 cfile_str2ind $SRCDIR/rr_cs.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
110
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
111 if [ "$GPRS" = 1 ]
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
112 then
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
113 cfile_str2ind $SRCDIR/rr_gprs.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
114 cfile_str2ind $SRCDIR/rr_datg.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
115 cfile_str2ind $SRCDIR/rr_attg.c
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
116 fi
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
117
268373943f45 rr.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
118 cfile_str2ind $SRCDIR/rr_em.c