annotate components/sm @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents ad7f986afae3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
194
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building sm.lib from the TCS3.2 source
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 if [ "$SRVC" != 0 ]
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 then
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 if [ "$SRVC" = 1 ]
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 then
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DFF_FAX"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 fi
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 fi
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 CPPFLAGS="$CPPFLAGS -DMMI=$MMI"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 if [ "$MMI" = 0 ]
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 then
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 CPPFLAGS="$CPPFLAGS -DACI"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42 elif [ "$MMI" = 2 ]
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 then
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DMFW"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 fi
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DGPRS"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49 CPPFLAGS="$CPPFLAGS -DENTITY_SM"
482
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 194
diff changeset
50 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
ad7f986afae3 pass -DCHIPSET and -DBOARD for all TCS3.2 components
Mychaela Falconia <falcon@freecalypso.org>
parents: 194
diff changeset
51 CPPFLAGS="$CPPFLAGS -DBOARD=41"
194
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
52
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 # Includes
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 SRCDIR=$SRC/g23m-gprs/sm
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/inc"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58 CPPFLAGS="$CPPFLAGS -I$SRC/$GPF/inc"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/$CONDAT/com/include"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
60 CPPFLAGS="$CPPFLAGS -I../../$CDGINC"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
61 CPPFLAGS="$CPPFLAGS -I../../$CDGPRIM"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
62 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I.."
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
64 CPPFLAGS="$CPPFLAGS -I../config"
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 # Source modules
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 cfile_str2ind $SRCDIR/sm.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69 cfile_str2ind $SRCDIR/sm_aci_output_handler.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/sm_context_control.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/sm_context_deactivate_control.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 cfile_str2ind $SRCDIR/sm_debug.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
73 cfile_str2ind $SRCDIR/sm_dispatch_message.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
74 cfile_str2ind $SRCDIR/sm_dispatcher.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
75 cfile_str2ind $SRCDIR/sm_memory_handler.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
76 cfile_str2ind $SRCDIR/sm_mm_output_handler.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
77 cfile_str2ind $SRCDIR/sm_network_control.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
78 cfile_str2ind $SRCDIR/sm_pei.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
79 cfile_str2ind $SRCDIR/sm_qos.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
80 cfile_str2ind $SRCDIR/sm_sequencer.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
81 cfile_str2ind $SRCDIR/sm_tft.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
82 cfile_str2ind $SRCDIR/sm_timer_handler.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
83 cfile_str2ind $SRCDIR/sm_upm_output_handler.c
62da0aa197de sm.lib compiles
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
84 cfile_str2ind $SRCDIR/sm_user_plane_control.c